changed table to use system name and not id #497 #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelvdavies
reviewed
Apr 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #505 +/- ##
===========================================
+ Coverage 94.03% 94.06% +0.02%
===========================================
Files 62 62
Lines 17712 17793 +81
Branches 2044 2403 +359
===========================================
+ Hits 16656 16737 +81
+ Misses 1054 1050 -4
- Partials 2 6 +4 ☔ View full report in Codecov by Sentry. |
joelvdavies
requested changes
Apr 23, 2024
|
Can the system be grouped by the system id and not the name please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed items table to display system name rather than system ID.
System objects are fetched from backend from set of system IDs - set of IDs is created from items data
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
closes #497